Fix System Icons when closing a thread#64
Closed
iamEvanYT wants to merge 10 commits intomodmail-dev:masterfrom
iamEvanYT:patch-2
Closed
Fix System Icons when closing a thread#64iamEvanYT wants to merge 10 commits intomodmail-dev:masterfrom iamEvanYT:patch-2
iamEvanYT wants to merge 10 commits intomodmail-dev:masterfrom
iamEvanYT:patch-2
Conversation
Taaku18
requested changes
Oct 17, 2022
Contributor
Taaku18
left a comment
Taaku18
left a comment
There was a problem hiding this comment.
Thanks for the commit, as I responded in Discord:
We don't really want to use an image attachment here, since the image may get deleted.
You should instead create an/imgdirectory under the/static(so create/static/img). Then upload the icon assystem-icon.pngto/static/img/system-icon.png, and return a reference to the image's static path.
Contributor
Author
|
ill do it in another pull request since i messed up... |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.