fix: show forwarded message in logviewer.#3414
Conversation
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
lorenzo132
requested review from
a team,
RealCyGuy,
StephenDaDev,
Taaku18,
martinbndr and
sebkuip
and removed request for
sebkuip
StephenDaDev
added
the
changelog
SoAJeff
left a comment
SoAJeff
left a comment
There was a problem hiding this comment.
Appreciate the quick turn-around on getting a fix for this. As a mod in a server that receives a lot of forwarded messages in Modmail threads to us, the recent additions in supporting forwarded messages both on the bot side and the logviewer side have been very helpful to us.
Just one minor correction I saw to improve usability for mods reviewing Modmail logs after the fact.
I believe it is a safer aproach to remove the jumpurl from logviewer, since it shows in the threadchannel already.
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
I've tested the message forwarding locally and it seems to work just fine. I find one issue with the code regarding the placement of an import. For the rest it looks all good. If you can get this one change fixed up it should be all good to merge.
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
LGTM now. All thing pointed out have been resolved.
StephenDaDev
left a comment
StephenDaDev
left a comment
There was a problem hiding this comment.
Looks good, tested working.
5 participants
Forwarded message now will show correctly in logviewer.
