Fix essential modmail code not loading when the registry population fails#3330
Merged
Taaku18 merged 5 commits intomodmail-dev:developmentfrom Oct 27, 2024
Merged
Fix essential modmail code not loading when the registry population fails#3330Taaku18 merged 5 commits intomodmail-dev:developmentfrom
Taaku18 merged 5 commits intomodmail-dev:developmentfrom
Conversation
raidensakura
added a commit
to raidensakura/modmail
that referenced
this pull request
Mar 31, 2024
Taaku18
approved these changes
Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3328
When loading cogs the bot also populates the registry. When this fails the entire cog loading stops causing major parts of the code to fail to load.
This PR fixes this by implementing proper error handling to the registry population code.