Optimized "blocked" command#3242
Merged
Taaku18 merged 1 commit intomodmail-dev:developmentfrom Jan 21, 2023
khakers:master
Merged
Optimized "blocked" command#3242Taaku18 merged 1 commit intomodmail-dev:developmentfrom khakers:master
Taaku18 merged 1 commit intomodmail-dev:developmentfrom
khakers:master
Conversation
We already have all the information we need to mention a user (their id) and fetching the information from discord will lead to rate limiting and extremely poor performance on large block lists for no gain.
Member
|
Can confirm this solves the issue |
Member
|
Also confirmed |
Merged
raidensakura
pushed a commit
to raidensakura/modmail
that referenced
this pull request
Apr 10, 2024
We already have all the information we need to mention a user (their id) and fetching the information from discord will lead to rate limiting and extremely poor performance on large block lists for no gain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issues those with large blocklists were having when attempting to use the
blockedcommand. Tested with 15k blocked user and had no performance problems (besides the memory usage going up by over 20MB).There are some more optimizations I can make to this method that'll either end up being adding to this PR or done in the future separately depending on my time constraints.