Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6549: remove usage of dfsql module #6550

Merged
merged 3 commits into from
Sep 12, 2023
Merged

FIX-#6549: remove usage of dfsql module #6550

merged 3 commits into from
Sep 12, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 11, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves dfsql doesn't work correctly with python 3.10 and 3.11 #6549
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6549: remove usage of 'dfsql' module
d3f333d 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
skip tests if needed
6d1d38b 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review September 11, 2023 23:02
@anmyachev anmyachev requested a review from a team as a code owner September 11, 2023 23:02
vnlitvinov
vnlitvinov reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, comment needs to be updated.

modin/experimental/sql/__init__.py Outdated Show resolved Hide resolved
@anmyachev @vnlitvinov
Update modin/experimental/sql/__init__.py
a4c87d5 
Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@dchigarev dchigarev merged commit 9886c01 into modin-project:master Sep 12, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6549 branch September 12, 2023 13:48
@YarShev YarShev mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov left review comments

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dfsql doesn't work correctly with python 3.10 and 3.11
3 participants
@anmyachev @vnlitvinov @dchigarev