Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6237: Log errors only from deepest modin layer #6238

Merged
merged 3 commits into from
Jun 6, 2023
Merged

FIX-#6237: Log errors only from deepest modin layer #6238

merged 3 commits into from
Jun 6, 2023

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: every layer of the modin stack logs the same error once #6237
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

mvashishtha added 2 commits June 5, 2023 16:46
FIX-modin-project#6237: Log errors only from deepest modin layer
538eeb2 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Fix mypy
3114314 
Signed-off-by: mvashishtha <mahesh@ponder.io>
RehanSD
RehanSD previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fix mypy
ed9eb52 
Signed-off-by: mvashishtha <mahesh@ponder.io>
mvashishtha
mvashishtha commented Jun 6, 2023
View reviewed changes
modin/utils.py
@@ -32,7 +32,7 @@
import pandas
import numpy as np

from pandas.util._decorators import Appender
from pandas.util._decorators import Appender # type: ignore
Copy link
Collaborator Author

@mvashishtha mvashishtha Jun 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove this, mypy fails. I don't understand how my changes brought about that situation, but here we are. The more specific # type: ignore[attr-defined] doesn't work either.

RehanSD
RehanSD approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvashishtha mvashishtha marked this pull request as ready for review June 6, 2023 12:01
@mvashishtha mvashishtha requested a review from a team as a code owner June 6, 2023 12:01
@devin-petersohn devin-petersohn merged commit cc69b3d into modin-project:master Jun 6, 2023
mvashishtha added a commit that referenced this pull request Jun 7, 2023
@mvashishtha
FIX-#6237: Log errors only from deepest modin layer (#6238)
8938727 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSD RehanSD RehanSD approved these changes

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: every layer of the modin stack logs the same error once
3 participants
@mvashishtha @devin-petersohn @RehanSD