FEAT-#6153: Add API layer implementations for some stat methods. #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2023 23:08
…methods. Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
7 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RehanSD
reviewed
May 18, 2023
Signed-off-by: mvashishtha <mahesh@ponder.io>
| @@ -377,17 +389,66 @@ | |||
| ) | |||
| ) | |||
|
|
|||
| def sem(self, *args, **kwargs): | |||
| def cov(self, other=None, pairwise=None, ddof=1, numeric_only=False, **kwargs): | |||
| from .dataframe import DataFrame | |||
Check notice
Code scanning / CodeQL
Cyclic import
| def sem(self, *args, **kwargs): | ||
| def cov(self, other=None, pairwise=None, ddof=1, numeric_only=False, **kwargs): | ||
| from .dataframe import DataFrame | ||
| from .series import Series |
Check notice
Code scanning / CodeQL
Cyclic import
| ) | ||
|
|
||
| def corr(self, other=None, pairwise=None, ddof=1, numeric_only=False, **kwargs): | ||
| from .dataframe import DataFrame |
Check notice
Code scanning / CodeQL
Cyclic import
|
|
||
| def corr(self, other=None, pairwise=None, ddof=1, numeric_only=False, **kwargs): | ||
| from .dataframe import DataFrame | ||
| from .series import Series |
Check notice
Code scanning / CodeQL
Cyclic import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
FEAT-#6153: Add API layer implementations for some stat methods.
Also fix some other expanding methods that were not tested and/or were broken. test_expanding wasn't running in CI until this commit, so we missed some errors.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date