Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6114: Fix series groupby list of numpy methods #6129

Merged
merged 3 commits into from
May 16, 2023
Merged

FIX-#6114: Fix series groupby list of numpy methods #6129

merged 3 commits into from
May 16, 2023

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

upstreaming ponder-org@c3013cd

Signed-off-by: mvashishtha mahesh@ponder.io

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: series groupby list of numpy methods gives wrong column names #6114
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

mvashishtha added 2 commits May 15, 2023 12:17
FIX-modin-project#6114: Fix series groupby list of numpy methods
8709aad 
Signed-off-by: mvashishtha <mahesh@ponder.io>
Fix all of test_groupby, I think
b71f2e9 
Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha marked this pull request as ready for review May 16, 2023 16:45
@mvashishtha mvashishtha requested a review from a team as a code owner May 16, 2023 16:45
RehanSD
RehanSD requested changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a quick comment!

modin/pandas/groupby.py Show resolved Hide resolved
RehanSD
RehanSD previously approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fix docstring
2c4e200 
Signed-off-by: mvashishtha <mahesh@ponder.io>
RehanSD
RehanSD approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RehanSD RehanSD merged commit 709a018 into modin-project:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSD RehanSD RehanSD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: series groupby list of numpy methods gives wrong column names
2 participants
@mvashishtha @RehanSD