-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#5650: Restore the right dtype for applying Series.cat #5651
FIX-#5650: Restore the right dtype for applying Series.cat #5651
Conversation
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good as a temporary solution, left couple of comments
# `pd.concat` doesn't preserve categorical dtype | ||
# if the dfs have categorical columns | ||
# so we intentionaly restore the right dtype. | ||
# TODO: revert the change when https://github.com/pandas-dev/pandas/issues/51362 is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've already raised a similar issue in modin, we should probably link it here as well: #2513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now, but we should consider closely watching for pandas-dev/pandas#51362 or, if it would get stuck, for other possible solutions in #2513, as for now categorical seems to not serve its purpose of saving memory when faced with a column-wise operation, which may result into an excessive memory consumption and out of memory issues.
Signed-off-by: Igoshev, Iaroslav iaroslav.igoshev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date