Skip to content

Comments

PERF-#5613: Optimize duplicated in case there is only one column partition#5640

Merged
anmyachev merged 5 commits intomodin-project:masterfrom
YarShev:dev/yigoshev-issue5613
Mar 3, 2023
Merged

PERF-#5613: Optimize duplicated in case there is only one column partition#5640
anmyachev merged 5 commits intomodin-project:masterfrom
YarShev:dev/yigoshev-issue5613

Conversation

@YarShev
Copy link
Collaborator

@YarShev YarShev commented Feb 8, 2023

Signed-off-by: Igoshev, Iaroslav iaroslav.igoshev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Optimize duplicated in case there is only one column partition #5613
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

YarShev
YarShev commented Feb 8, 2023
View reviewed changes
@YarShev YarShev marked this pull request as ready for review February 8, 2023 21:53
@YarShev YarShev requested a review from a team as a code owner February 8, 2023 21:53
anmyachev
anmyachev reviewed Feb 13, 2023
View reviewed changes
anmyachev
anmyachev reviewed Feb 13, 2023
View reviewed changes
@YarShev
PERF-modin-project#5613: Optimize duplicated in case there is only …
2c150ad 
…one column partition

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev
Remove new params
cda0b9c 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev YarShev force-pushed the dev/yigoshev-issue5613 branch from 6c185e1 to cda0b9c Compare March 1, 2023 14:26
dchigarev
dchigarev reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, left a couple of comments

anmyachev
anmyachev reviewed Mar 2, 2023
View reviewed changes
anmyachev
anmyachev reviewed Mar 2, 2023
View reviewed changes
@YarShev YarShev requested review from anmyachev and dchigarev March 2, 2023 15:22
@YarShev @dchigarev
Update modin/core/storage_formats/pandas/query_compiler.py
72a4fd7 
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev
YarShev commented Mar 2, 2023
View reviewed changes
dchigarev
dchigarev reviewed Mar 2, 2023
View reviewed changes
@YarShev
Address comment
f508fef 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
dchigarev
dchigarev approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anmyachev anmyachev merged commit 5010a6d into modin-project:master Mar 3, 2023
@anmyachev anmyachev mentioned this pull request Oct 14, 2023
Closed
@YarShev YarShev deleted the dev/yigoshev-issue5613 branch November 2, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmyachev anmyachev anmyachev approved these changes

@dchigarev dchigarev dchigarev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize duplicated in case there is only one column partition

3 participants

@YarShev @anmyachev @dchigarev