FIX-#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy
#5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DataFrameGroupBy Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
changed the title
value_counts method for SeriesGroupBy and DataFrameGroupBy
dchigarev
approved these changes
Dec 16, 2022
Done #5460 |
jkew
pushed a commit
to jkew/modin
that referenced
this pull request
Feb 28, 2023
… DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
jkew
added a commit
to jkew/modin
that referenced
this pull request
Feb 28, 2023
…upBy and DataFrameGroupBy (modin-project#5453)" This reverts commit 08dd22b.
jkew
pushed a commit
to jkew/modin
that referenced
this pull request
Feb 28, 2023
… DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
jkew
added a commit
to jkew/modin
that referenced
this pull request
Feb 28, 2023
…upBy and DataFrameGroupBy (modin-project#5453)" This reverts commit 4a388ca.
jkew
pushed a commit
to ponder-org/modin-public
that referenced
this pull request
Mar 1, 2023
… DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
jkew
added a commit
to ponder-org/modin-public
that referenced
this pull request
Mar 3, 2023
* FIX-modin-project#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> * WIP GroupBy * Seemingly working w/ Ponder and Modin * Maintain proper value ordering for single group-by operations * linter updates from black on the files that have changed * When normalize is used, or the groupby was performed with as_index=False, default to pandas. With ponder this will result in a NotImplemented error currently. * Remove _to_pandas() by implementing sort_index on Series on the service side * | Object | call | Pushdown? | Compatibility | | --- | --- | --- | --- | | DataFrameGroupBy | value_counts() | Full | PASS | | DataFrameGroupBy | value_counts(ascending=True) |Full | PASS | | DataFrameGroupBy | value_counts(ascending=False) | Full |PASS | | DataFrameGroupBy | value_counts(sort=False) |Full | PASS | | DataFrameGroupBy | value_counts(sort=True) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=False) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=True) | | FAIL | | DataFrame | groupby(as_index=False) | | FAIL | | DataFrameGroupBy | value_counts(dropna=False) | Full | PASS | DataFrameGroupBy | value_counts(dropna=True) | |FAIL $\color{red}{\text{NOTE: For MultiIndex GroupBys the n+1 level index is ignored in the sorting.}}$ --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> Co-authored-by: Anatoly Myachev <anatoly.myachev@intel.com>
vnlitvinov
pushed a commit
to vnlitvinov/modin
that referenced
this pull request
Mar 16, 2023
* FIX-modin-project#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> * WIP GroupBy * Seemingly working w/ Ponder and Modin * Maintain proper value ordering for single group-by operations * linter updates from black on the files that have changed * When normalize is used, or the groupby was performed with as_index=False, default to pandas. With ponder this will result in a NotImplemented error currently. * Remove _to_pandas() by implementing sort_index on Series on the service side * | Object | call | Pushdown? | Compatibility | | --- | --- | --- | --- | | DataFrameGroupBy | value_counts() | Full | PASS | | DataFrameGroupBy | value_counts(ascending=True) |Full | PASS | | DataFrameGroupBy | value_counts(ascending=False) | Full |PASS | | DataFrameGroupBy | value_counts(sort=False) |Full | PASS | | DataFrameGroupBy | value_counts(sort=True) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=False) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=True) | | FAIL | | DataFrame | groupby(as_index=False) | | FAIL | | DataFrameGroupBy | value_counts(dropna=False) | Full | PASS | DataFrameGroupBy | value_counts(dropna=True) | |FAIL $\color{red}{\text{NOTE: For MultiIndex GroupBys the n+1 level index is ignored in the sorting.}}$ --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> Co-authored-by: Anatoly Myachev <anatoly.myachev@intel.com>
vnlitvinov
pushed a commit
to vnlitvinov/modin
that referenced
this pull request
Mar 16, 2023
* FIX-modin-project#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> * WIP GroupBy * Seemingly working w/ Ponder and Modin * Maintain proper value ordering for single group-by operations * linter updates from black on the files that have changed * When normalize is used, or the groupby was performed with as_index=False, default to pandas. With ponder this will result in a NotImplemented error currently. * Remove _to_pandas() by implementing sort_index on Series on the service side * | Object | call | Pushdown? | Compatibility | | --- | --- | --- | --- | | DataFrameGroupBy | value_counts() | Full | PASS | | DataFrameGroupBy | value_counts(ascending=True) |Full | PASS | | DataFrameGroupBy | value_counts(ascending=False) | Full |PASS | | DataFrameGroupBy | value_counts(sort=False) |Full | PASS | | DataFrameGroupBy | value_counts(sort=True) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=False) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=True) | | FAIL | | DataFrame | groupby(as_index=False) | | FAIL | | DataFrameGroupBy | value_counts(dropna=False) | Full | PASS | DataFrameGroupBy | value_counts(dropna=True) | |FAIL $\color{red}{\text{NOTE: For MultiIndex GroupBys the n+1 level index is ignored in the sorting.}}$ --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> Co-authored-by: Anatoly Myachev <anatoly.myachev@intel.com>
vnlitvinov
pushed a commit
to vnlitvinov/modin
that referenced
this pull request
Mar 16, 2023
* FIX-modin-project#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> * WIP GroupBy * Seemingly working w/ Ponder and Modin * Maintain proper value ordering for single group-by operations * linter updates from black on the files that have changed * When normalize is used, or the groupby was performed with as_index=False, default to pandas. With ponder this will result in a NotImplemented error currently. * Remove _to_pandas() by implementing sort_index on Series on the service side * | Object | call | Pushdown? | Compatibility | | --- | --- | --- | --- | | DataFrameGroupBy | value_counts() | Full | PASS | | DataFrameGroupBy | value_counts(ascending=True) |Full | PASS | | DataFrameGroupBy | value_counts(ascending=False) | Full |PASS | | DataFrameGroupBy | value_counts(sort=False) |Full | PASS | | DataFrameGroupBy | value_counts(sort=True) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=False) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=True) | | FAIL | | DataFrame | groupby(as_index=False) | | FAIL | | DataFrameGroupBy | value_counts(dropna=False) | Full | PASS | DataFrameGroupBy | value_counts(dropna=True) | |FAIL $\color{red}{\text{NOTE: For MultiIndex GroupBys the n+1 level index is ignored in the sorting.}}$ --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> Co-authored-by: Anatoly Myachev <anatoly.myachev@intel.com>
vnlitvinov
pushed a commit
to vnlitvinov/modin
that referenced
this pull request
Mar 16, 2023
* FIX-modin-project#4154: add value_counts method for SeriesGroupBy and DataFrameGroupBy (modin-project#5453) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> * WIP GroupBy * Seemingly working w/ Ponder and Modin * Maintain proper value ordering for single group-by operations * linter updates from black on the files that have changed * When normalize is used, or the groupby was performed with as_index=False, default to pandas. With ponder this will result in a NotImplemented error currently. * Remove _to_pandas() by implementing sort_index on Series on the service side * | Object | call | Pushdown? | Compatibility | | --- | --- | --- | --- | | DataFrameGroupBy | value_counts() | Full | PASS | | DataFrameGroupBy | value_counts(ascending=True) |Full | PASS | | DataFrameGroupBy | value_counts(ascending=False) | Full |PASS | | DataFrameGroupBy | value_counts(sort=False) |Full | PASS | | DataFrameGroupBy | value_counts(sort=True) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=False) |Full | PASS | | DataFrameGroupBy | value_counts(normalize=True) | | FAIL | | DataFrame | groupby(as_index=False) | | FAIL | | DataFrameGroupBy | value_counts(dropna=False) | Full | PASS | DataFrameGroupBy | value_counts(dropna=True) | |FAIL $\color{red}{\text{NOTE: For MultiIndex GroupBys the n+1 level index is ignored in the sorting.}}$ --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> Co-authored-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date