-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4017: Fix OmniSci engine enabling for IO functions #4037
Conversation
Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
86b196f
to
63e07dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4037 +/- ##
===========================================
- Coverage 80.75% 54.50% -26.26%
===========================================
Files 201 187 -14
Lines 16671 15893 -778
===========================================
- Hits 13463 8662 -4801
- Misses 3208 7231 +4023
Continue to review full report at Codecov.
|
…import Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
Hi @modin-project/modin-core , please take a look at this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyskov, LGTM, thanks! Ping me when tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Alexander Myskov alexander.myskov@intel.com
What do these changes do?
The problem is that when
FactoryDispatcher
is imported, commandEngine.subscribe(FactoryDispatcher._update_factory)
is executed beforeEngine
config correction inEngine.subscribe(_update_engine)
, that leads to incorrect factory search. To fix it we need to updateEngine
beforeFactoryDispatcher
import.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
StorageFormat
config doesn't work with OmniSci IO functions #4017docs/development/architecture.rst
is up-to-date