-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-#3904: Improving Modin README #3929
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
797bcd7
DOCS-#3904: Improving Modin README
naren-ponder abfe6c2
omnisci change
naren-ponder 5786ed2
first comment round
naren-ponder a77d66e
address some more comments
naren-ponder 60ee81e
small grammar fix
naren-ponder a1aad8d
update rebase
naren-ponder 9db68d8
development change
naren-ponder 4703fbe
address another round and fix whitespace
naren-ponder 10e4584
address comments 4
naren-ponder 5a4144b
update README structure with proposed changes
naren-ponder ffce9a4
Add links at the end
naren-ponder aabc6d3
add modin engine configs
naren-ponder 354e060
update Slack link
naren-ponder b31afff
Apply suggestions from code review 5
naren-ponder da7ea45
change bold to italics
naren-ponder 85fac02
Apply suggestions from code review 6
naren-ponder d5e612a
fix some grammar and paragraph structure
naren-ponder 39ed47e
restructure resources section
naren-ponder 6d44ec7
some minor fixes
naren-ponder 3d7b5a8
fix faq links
naren-ponder af88e42
add TLDR to faq
naren-ponder 7cbbc01
fix broken links in documentation
naren-ponder 7770a3a
fix some more links
naren-ponder 8aeb23e
change section title
naren-ponder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update Slack link
Signed-off-by: Naren Krishna <naren@ponder.io>
- Loading branch information
commit 354e06067b14894c4d4170ef919c3d3515e83ba4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add also link on conda-forge here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've added links to conda-forge in the installation instructions. If we add an extra badge for conda-forge up in the top section, the badges will span across two lines, which doesn't look as great.