REFACTOR-#3885: Move PandasDataframePartitionManager.concatenate to a utils #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…catenate to a utils Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #3892 +/- ##
===========================================
- Coverage 85.44% 25.60% -59.84%
===========================================
Files 198 185 -13
Lines 16456 15171 -1285
===========================================
- Hits 14061 3885 -10176
- Misses 2395 11286 +8891
Continue to review full report at Codecov.
|
|
|
|
devin-petersohn
approved these changes
Jan 10, 2022
YarShev
changed the title
|
I wonder if general.py would be a better name for the file like we have general stuff in modin.pandas.general.py? @naren-ponder, please do not forget linking an issue in PRs description in future (I did it). |
dchigarev
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
LGTM!
I'm fine with the new file being named utils.py, for me, general.py seems like a set of general methods for Modin dataframe objects, when the concatenate is literally an utility function to do a certain thing on pandas DataFrames inside partition manager.
That makes sense |
dchigarev
pushed a commit
to dchigarev/modin
that referenced
this pull request
Jan 12, 2022
…catenate to a utils (modin-project#3892) Signed-off-by: Naren Krishna <naren@ponder.io>
mvashishtha
pushed a commit
to devin-petersohn/modin
that referenced
this pull request
Jan 19, 2022
…catenate to a utils (modin-project#3892) Signed-off-by: Naren Krishna <naren@ponder.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naren Krishna naren@ponder.io
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date