-
Notifications
You must be signed in to change notification settings - Fork 670
REFACTOR-#2059: Consolidate environment variables #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#2059: Consolidate environment variables #2189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
- Coverage 82.63% 73.29% -9.34%
==========================================
Files 116 114 -2
Lines 12532 12437 -95
==========================================
- Hits 10356 9116 -1240
- Misses 2176 3321 +1145
Continue to review full report at Codecov.
|
dcd8de7 to
f884996
Compare
f884996 to
e74472f
Compare
|
LGTM, let's wait @devin-petersohn. |
|
Anything needed from me to get this merged? |
I think nothing is needed. |
|
@vnlitvinov please restart CI. Tests for Omnisci backend should be working now. |
|
After this I will do merge. |
Other parts of Modin not adapted yet Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
…BACKEND Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
…S_ADDRESS Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
… logging Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
… see modin-project#2194 Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
df105d9 to
433b797
Compare
|
I've rebased off |
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
|
@anmyachev @devin-petersohn I believe the failure in running OmniSci tests isn't related to this PR (the tests actually pass, all the things crashed and burnt during the exit of the interpreter according to the logs). I think we should merge this PR. |
devin-petersohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's quite clean.
Can we create an issue to add this list to the documentation?
What do these changes do?
Consolidate all environment variables used for Modin configuration in single file.
Also introduce the API to manage configuration, could be generalized later for non-envinronment-based options.
Also provide short help on existing options by running
python -m modin.config.Current help
flake8 modinblack --check modingit commit -s