REFACTOR-#2011: move default_to_pandas in groupby to backend #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
|
|
|
Codecov Report
@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
+ Coverage 81.79% 82.21% +0.42%
==========================================
Files 79 79
Lines 9403 9581 +178
==========================================
+ Hits 7691 7877 +186
+ Misses 1712 1704 -8
Continue to review full report at Codecov.
|
YarShev
reviewed
Sep 8, 2020
| assert isinstance( | ||
| by, type(query_compiler) | ||
| ), "Can only use groupby reduce with another Query Compiler" | ||
| if not isinstance(by, type(query_compiler)): |
Collaborator
There was a problem hiding this comment.
What cases this is working now for?
Collaborator
Author
There was a problem hiding this comment.
It works for all cases we couldn't handle in DataFrame.groupby and transform by to a QueryCompiler. The case of our interest is NYC Taxi query like the following:
df = df.groupby(["b", df["c"].dt.year]).size()
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…kend (modin-project#2041) Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In OmniSci backend we can handle some cases of
groubywherebyholds both column names and series. We need this feature for NYC Taxi benchmark. To utilize backend support we need to movedefault_to_pandascall from API level to the backend.flake8 modinblack --check modingit commit -s