-
Notifications
You must be signed in to change notification settings - Fork 670
Simulate cluster for testing remote context #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
- Coverage 82.47% 79.12% -3.36%
==========================================
Files 100 102 +2
Lines 10378 10456 +78
==========================================
- Hits 8559 8273 -286
- Misses 1819 2183 +364
Continue to review full report at Codecov.
|
c8d94fd to
91ac9fe
Compare
|
@anmyachev I've dismissed your review as I've dropped quite a few patches which weren't needed for this feature - I'm going to extract fixes for issues I found during simulated cloud testing in separate issues and PRs. Please re-review. |
|
LGTM! Please resolve conflicts. |
…n requested Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Tests still not start if modin is not installed Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
…imulation Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
…guments Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
646e670 to
b169c78
Compare
anmyachev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What do these changes do?
Add optional switch for running tests
--sumulate-cloudwith valuesoff(normal behaviour),normal(simulate cluster with Modin in non-experimental mode) andexperimental(simulate cluster with Modin in experimental mode).When
--simulate-cloud=off(default), no tests are impacted.Tests failing in simulated mode are a subject for subsequent issues and pull requests.
Also make rpyc server (on remote side) to pick the same port as the forwarded port. This allows parallel connects to single cluster, proper connects to an already running cluster, and parallel local testing (both as
pytest -n JOBSand by several developers simulateneously).flake8 modinblack --check modingit commit -s