FIX-#1953: Fix computing of reduced indices for reduction operation #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
from
21b7083
to
dda769e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
+ Coverage 81.80% 81.88% +0.07%
==========================================
Files 79 79
Lines 9389 9434 +45
==========================================
+ Hits 7681 7725 +44
- Misses 1708 1709 +1
Continue to review full report at Codecov.
|
|
|
|
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
2 times, most recently
from
23d2dfa
to
63d599e
Compare
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
3 times, most recently
from
a96eb52
to
985ca0b
Compare
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
from
985ca0b
to
daccc75
Compare
|
@devin-petersohn , just a friendly reminder to review. |
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
3 times, most recently
from
298f430
to
4e17132
Compare
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
from
4e17132
to
18fe443
Compare
|
@dchigarev , your guessing with propagating |
|
The point is that a length of reduced index sometimes can be not equal one. That's why reduced index should be recomputed in some cases. We could propagate recomputing of reduced index (row_lengths and columns_widths as well) into |
|
@YarShev yeah, I think it's a good idea. At |
There was a problem hiding this comment.
I agree, precomputing row_lengths and column_widths is an optimization. If it is off we should just clear it as you say @YarShev and @dchigarev. The internal system will materialize them when they are needed and they should be correct then.
Was there a lot of code moved around in this PR? It makes the diff a little hard to read.
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
3 times, most recently
from
cddb5e5
to
b817bac
Compare
|
@devin-petersohn , @dchigarev , done as we discussed. |
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
from
b817bac
to
8c97810
Compare
for reduction operation Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
YarShev
force-pushed
the
dev/yigoshev-issue1953
branch
from
8c97810
to
8fec8a3
Compare
|
@devin-petersohn , just a friendly reminder to review. |
devin-petersohn
approved these changes
Sep 3, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…ct#1960) for reduction operation Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com
What do these changes do?
flake8 modinblack --check modingit commit -s