-
Notifications
You must be signed in to change notification settings - Fork 670
REFACTOR-#1879: Move logic for groupby.agg into query compiler
#1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This one is the last blocker for #1871, could you please look at it? @devin-petersohn @YarShev |
…compiler Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
4be569e to
a0b66c4
Compare
|
@ienkovich I just rebased and pushed. I believe previous test failures were do to CI infra issues. |
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
+ Coverage 81.77% 81.80% +0.02%
==========================================
Files 79 79
Lines 9389 9403 +14
==========================================
+ Hits 7678 7692 +14
Misses 1711 1711
Continue to review full report at Codecov.
|
|
@ienkovich @YarShev This is ready for review |
|
Changes LGTM |
|
LGTM as well! |
…compiler (modin-project#1885) Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modinblack --check modingit commit -sadded andpassing