Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#1867: establish CI #1868
FIX-#1867: establish CI #1868
Changes from 36 commits
2a2f3ce
2119aeb
bc685cd
5ea4819
3024acf
b82c283
c896e55
4ed57db
4bd5102
bfa8aa1
880bc8f
18207ff
a415d60
9e6e289
d0b6ee8
8d7ce4a
52e4ba5
2fad256
67e378b
86a4b8d
970ebbf
bb79dcd
aee03e9
fb15fae
2671880
663db73
87102e6
d6edee1
031b10d
7b7e563
ed5fdeb
d18daa1
ae33bf6
23e0da7
9a64063
ba4797d
84c9592
95ac6b6
7609a07
af23f3b
7fd6919
7a6383e
ab60ee5
1b30bbb
8f72b9e
9a92f9d
8ae3eae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whose job is to clean the cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, the old cache will be deleted only if the total amount of caches stored under different keys exceeds the 5GB limit.
https://github.com/actions/cache#cache-limits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we have so many concurrent CI runs that cache is out of space?..
And the question still stays - what is going to clean the cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So - how many different variants of the cache (keys) we have - 12 (2 - OS, 3 - python versions, 2 managers - pip and conda). At the moment, one cache write for pep is <50MB, one cache for conda is <300MB. Less than 3GB in total for one CI run. So part of cache will be clean up by 2 concurrent CI runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not use the Conda cache, only pip. Then problems should not arise up to 10 parallel CI runs. Need to look at performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep in mind this restriction then, and use cache for all runs for now, as I don't think we have enough resources for a lot of concurrent CI runs anyway.
Maybe dropping a comment about that in the
.yml
file would be good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the conda cache doesn't make performance worse. So let's cache only pip packages.