-
Notifications
You must be signed in to change notification settings - Fork 670
FIX-#1803: Change the order of execution engine change callbacks #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#1803: Change the order of execution engine change callbacks #1805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
+ Coverage 82.98% 84.28% +1.30%
==========================================
Files 77 77
Lines 8282 8281 -1
==========================================
+ Hits 6873 6980 +107
+ Misses 1409 1301 -108
Continue to review full report at Codecov.
|
…allbacks Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
1eedb67 to
f94e875
Compare
devin-petersohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vnlitvinov, LGTM
…allbacks (modin-project#1805) Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov vasilij.n.litvinov@intel.com
What do these changes do?
There are cases where callback order matters. For instance, whenever we import
pd.DataFramethe engines must be initialized.This is especially needed for implementing a "remote Ray" engine (which will be initialized separately).
flake8 modinblack --check modingit commit -s