-
Notifications
You must be signed in to change notification settings - Fork 670
FEAT-#1194 #1283 #1138: Add Series.rolling, DataFrame.rolling
#1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#1194 #1283 #1138: Add Series.rolling, DataFrame.rolling
#1758
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
- Coverage 84.23% 81.85% -2.38%
==========================================
Files 77 77
Lines 8056 8153 +97
==========================================
- Hits 6786 6674 -112
- Misses 1270 1479 +209
Continue to review full report at Codecov.
|
0b6381f to
156043b
Compare
a182e73 to
0fc0718
Compare
f142027 to
40ba586
Compare
|
@devin-petersohn Could you review this, please? |
devin-petersohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks great, a couple of minor formatting/refactorings requested. Thanks!
40ba586 to
d1e0968
Compare
Series.rolling, DataFrame.rolling functionality to enable rolling window operations
f9bc79e to
d010ff2
Compare
Series.rolling, DataFrame.rolling functionality to enable rolling window operationsSeries.rolling, DataFrame.rolling functionality to enable rolling window operations
99dbe3f to
1f6a52f
Compare
|
@devin-petersohn please, take a look on CI scripts which I changed for adding new |
devin-petersohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting changes for cleanliness.
Also please change rolling_rol to rolling and rolling_win to window.
…eries.rolling`, `DataFrame.rolling` functionality to enable rolling window operations Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
1f6a52f to
828d7e5
Compare
|
@devin-petersohn Formatting/naming was fixed. |
devin-petersohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prutskov great addition!
Series.rolling, DataFrame.rolling functionality to enable rolling window operationsSeries.rolling, DataFrame.rolling
Signed-off-by: Alexey Prutskov alexey.prutskov@intel.com
What do these changes do?
These changes include implementation of
DataFrame.rollingandSeries.rollingand implementation ofWindowandRollingclasses to do window operations in modin.flake8 modinblack --check modingit commit -srollingAPI for Dataframe and Series #1138