Move logic of sort_values into the query compiler
#1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
- Coverage 82.39% 78.39% -4.00%
==========================================
Files 77 77
Lines 7948 7981 +33
==========================================
- Hits 6549 6257 -292
- Misses 1399 1724 +325
Continue to review full report at Codecov.
|
5 tasks
|
|
|
anmyachev
requested changes
Jul 18, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
YarShev
previously approved these changes
Jul 20, 2020
anmyachev
reviewed
Jul 20, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
This test runs inplace sort of dataframe that has non-numerical index Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com>
anmyachev
requested changes
Jul 20, 2020
Co-authored-by: anmyachev <45976948+anmyachev@users.noreply.github.com>
anmyachev
approved these changes
Jul 21, 2020
|
@YarShev are you OK with the last changes? |
|
@anmyachev , yes, LGTM! |
YarShev
approved these changes
Jul 21, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
* Move logic of `sort_values` into the query compiler Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> * Remove dead code Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> * Add back `"kind"` parameter Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> * Added a test for bug modin-project#1743 This test runs inplace sort of dataframe that has non-numerical index Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com> * Apply suggestions from code review Co-authored-by: anmyachev <45976948+anmyachev@users.noreply.github.com> Co-authored-by: Gregory Shimansky <gregory.shimansky@intel.com> Co-authored-by: anmyachev <45976948+anmyachev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modinblack --check modingit commit -sadded andpassing