[FIX] Fix #1683 - losing index names in pd.concat #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
===========================================
- Coverage 84.10% 73.72% -10.38%
===========================================
Files 77 77
Lines 7950 7988 +38
===========================================
- Hits 6686 5889 -797
- Misses 1264 2099 +835
Continue to review full report at Codecov.
|
|
|
|
amyskov
previously approved these changes
Jul 3, 2020
devin-petersohn
requested changes
Jul 7, 2020
Collaborator
devin-petersohn
left a comment
devin-petersohn
left a comment
There was a problem hiding this comment.
Thanks @dchigarev, left some comments for you.
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
anmyachev
reviewed
Jul 20, 2020
anmyachev
reviewed
Jul 20, 2020
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
anmyachev
reviewed
Jul 20, 2020
anmyachev
reviewed
Jul 20, 2020
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
devin-petersohn
requested changes
Jul 20, 2020
Collaborator
devin-petersohn
left a comment
devin-petersohn
left a comment
There was a problem hiding this comment.
@dchigarev Looks good, I would prefer one change for maintainability/simplicity. It might be good to add more specific type hints to the _determine_name function for the list portion.
from typing import List
...
def _determine_name(objs: List[QueryCompiler], axis: int):
...Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
anmyachev
approved these changes
Jul 21, 2020
Collaborator
anmyachev
left a comment
anmyachev
left a comment
There was a problem hiding this comment.
LGTM. @devin-petersohn , @amyskov ?
amyskov
reviewed
Jul 22, 2020
dchigarev
changed the title
devin-petersohn
approved these changes
Jul 22, 2020
| pd.DEFAULT_NPARTITIONS = 4 | ||
|
|
||
|
|
||
| def generate_dfs(): |
Collaborator
There was a problem hiding this comment.
Moving this is fine for this PR, but in the future I prefer new "REFACTOR" PRs for moved code so we can keep a more detailed commit history.
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…-project#1684) Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix of #1683:
pd.concatlosing indices namesflake8 modinblack --check modingit commit -s