Skip to content

Fixed #1490. New column case is checked first in __setitem__ #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gshimansky merged 2 commits into from
May 28, 2020
Merged

Fixed #1490. New column case is checked first in __setitem__ #1495

gshimansky merged 2 commits into from
May 28, 2020

Conversation

@gshimansky
Copy link
Collaborator

@gshimansky gshimansky commented May 27, 2020

Signed-off-by: Gregory Shimansky gregory.shimansky@intel.com

What do these changes do?

  • passes flake8 modin
  • passes black --check modin
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing

@gshimansky
Fixed modin-project#1490. New column case is checked first in __setit…
0bd9cda 
…em__

Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com>
@gshimansky gshimansky mentioned this pull request May 27, 2020
Closed
@modin-bot
Copy link

modin-bot commented May 27, 2020 •
edited
Loading

TeamCity Python test results bot

Tests PASSed

Tests Logs 
-rfE --tb=native modin/pandas/test/test_io.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: xdist-1.32.0, custom-exit-code-0.3.0, forked-1.1.3, testmon-1.0.2, cov-2.9.0
collected 78 items

modin/pandas/test/test_io.py ...............s.........s..............s.. [ 55%]
............s..s.X.....s........ss.                                      [100%]


TOTAL                                                               6474   4122    36%


=========== 69 passed, 8 skipped, 1 xpassed, 103 warnings in 14.05s ============
Closing remaining open files:test_write_pandas.hdf...donetest_write_modin.hdf...done
-rfE --tb=native -n=48 modin/pandas/test/test_series.py modin/pandas/test/test_dataframe.py modin/pandas/test/test_concat.py modin/pandas/test/test_groupby.py modin/pandas/test/test_reshape.py modin/pandas/test/test_general.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: xdist-1.32.0, custom-exit-code-0.3.0, forked-1.1.3, testmon-1.0.2, cov-2.9.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [15273] / gw1 [15273] / gw2 [15273] / gw3 [15273] / gw4 [15273] / gw5 [15273] / gw6 [15273] / gw7 [15273] / gw8 [15273] / gw9 [15273] / gw10 [15273] / gw11 [15273] / gw12 [15273] / gw13 [15273] / gw14 [15273] / gw15 [15273] / gw16 [15273] / gw17 [15273] / gw18 [15273] / gw19 [15273] / gw20 [15273] / gw21 [15273] / gw22 [15273] / gw23 [15273] / gw24 [15273] / gw25 [15273] / gw26 [15273] / gw27 [15273] / gw28 [15273] / gw29 [15273] / gw30 [15273] / gw31 [15273] / gw32 [15273] / gw33 [15273] / gw34 [15273] / gw35 [15273] / gw36 [15273] / gw37 [15273] / gw38 [15273] / gw39 [15273] / gw40 [15273] / gw41 [15273] / gw42 [15273] / gw43 [15273] / gw44 [15273] / gw45 [15273] / gw46 [15273] / gw47 [15273]

........................................................................ [  0%]
........................................................................ [  0%]
........................................................................ [  1%]
........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  2%]
........................................................................ [  3%]
........................................................................ [  3%]
..............................................................s......... [  4%]
........................................................................ [  4%]
................................................................s....... [  5%]
....................................................................s... [  5%]
........................................................................ [  6%]
......................................................................... [  6%]
........................................................................ [  7%]
........................................................................ [  7%]
........................................................................ [  8%]
........................................................................ [  8%]
........................................................................ [  8%]
.....s.......................s.......................................... [  9%]
........................................................................ [  9%]
........................................................................ [ 10%]
..........................................s............................. [ 10%]
........................................................................ [ 11%]
........................................................................ [ 11%]
........................................................................ [ 12%]
........................................................................ [ 12%]
........................................................................ [ 13%]
........................................................................ [ 13%]
......................................................................... [ 14%]
........................................................................ [ 14%]
........................................................................ [ 15%]
........................................................................ [ 15%]
........................................................................ [ 16%]
........................................................................ [ 16%]
........................................................................ [ 16%]
........................................................................ [ 17%]
........................................................................ [ 17%]
........................................................................ [ 18%]
........................................................................ [ 18%]
........................................................................ [ 19%]
........................................................................ [ 19%]
........................................................................ [ 20%]
........................................................................ [ 20%]
........................................................................ [ 21%]
........................................................................ [ 21%]
........................................................................ [ 22%]
....s................................................................... [ 22%]
........................................................................ [ 23%]
........................................................................ [ 23%]
........................................................................ [ 24%]
........................................................................ [ 24%]
........................................................................ [ 24%]
..............sssss.ssssss...s..sss..s.................................. [ 25%]
........................................................................ [ 25%]
........................................................................ [ 26%]
........................................................................ [ 26%]
........................................................................ [ 27%]
........................................................................ [ 27%]
........................................................................ [ 28%]
........................................................................ [ 28%]
........................................................................ [ 29%]
........................................................................ [ 29%]
........................................................................ [ 30%]
........................................................................ [ 30%]
........................................................................ [ 31%]
........................................................................ [ 31%]
........................................................................ [ 32%]
........................................................................ [ 32%]
......................................................................... [ 33%]
........................................................................ [ 33%]
........................................................................ [ 33%]
........................................................................ [ 34%]
........................................................................ [ 34%]
........................................................................ [ 35%]
........................................................................ [ 35%]
........................................................................ [ 36%]
......................ss................................................. [ 36%]
......................................................................... [ 37%]
........................................................................ [ 37%]
........................................................................ [ 38%]
......................................................................... [ 38%]
........................................................................ [ 39%]
......................................................................... [ 39%]
........................................................................ [ 40%]
........................................................................ [ 40%]
........................................................................ [ 41%]
........................................................................ [ 41%]
........................................................................ [ 42%]
........................................................................ [ 42%]
........................................................................ [ 42%]
........................................................................ [ 43%]
........................................................................ [ 43%]
........................................................................ [ 44%]
......................................................................... [ 44%]
......................................................................... [ 45%]
........................................................................ [ 45%]
........................................................................ [ 46%]
.......................................................................... [ 46%]
........................................................................ [ 47%]
........................................................................ [ 47%]
........................................................................ [ 48%]
........................................................................ [ 48%]
........................................................................ [ 49%]
........................................................................ [ 49%]
........................................................................ [ 50%]
........................................................................ [ 50%]
........................................................................ [ 50%]
........................................................................ [ 51%]
........................................................................ [ 51%]
......................................................................... [ 52%]
........................................................................ [ 52%]
........................................................................ [ 53%]
........................................................................ [ 53%]
........................................................................ [ 54%]
......................................................................... [ 54%]
........................................................................ [ 55%]
........................................................................ [ 55%]
........................................................................ [ 56%]
........................................................................ [ 56%]
........................................................................ [ 57%]
........................................................................ [ 57%]
........................................................................ [ 58%]
........................................................................ [ 58%]
........................................................................ [ 59%]
........................................................................ [ 59%]
........................................................................ [ 59%]
........................................................................ [ 60%]
........................................................................ [ 60%]
........................................................................ [ 61%]
........................................................................ [ 61%]
........................................................................ [ 62%]
........................................................................ [ 62%]
........................................................................ [ 63%]
......................................................................... [ 63%]
........................................................................ [ 64%]
........................................................................ [ 64%]
........................................................................ [ 65%]
........................................................................ [ 65%]
........................................................................ [ 66%]
........................................................................ [ 66%]
........................................................................ [ 67%]
........................................................................ [ 67%]
......................................................................... [ 67%]
........................................................................ [ 68%]
........................................................................ [ 68%]
........................................................................ [ 69%]
........................................................................ [ 69%]
........................................................................ [ 70%]
......................................................................... [ 70%]
........................................................................ [ 71%]
........................................................................ [ 71%]
........................................................................ [ 72%]
........................................................................ [ 72%]
........................................................................ [ 73%]
........................................................................ [ 73%]
........................................................................ [ 74%]
........................................................................ [ 74%]
......................................................................... [ 75%]
........................................................................ [ 75%]
........................................................................ [ 76%]
........................................................................ [ 76%]
........................................................................ [ 76%]
......................................................................... [ 77%]
........................................................................ [ 77%]
........................................................................ [ 78%]
........................................................................ [ 78%]
........................................................................ [ 79%]
........................................................................ [ 79%]
........................................................................ [ 80%]
........................................................................ [ 80%]
........................................................................ [ 81%]
........................................................................ [ 81%]
........................................................................ [ 82%]
........................................................................ [ 82%]
........................................................................ [ 83%]
........................................................................ [ 83%]
........................................................................ [ 84%]
........................................................................ [ 84%]
........................................................................ [ 84%]
........................................................................ [ 85%]
........................................................................ [ 85%]
........................................................................ [ 86%]
........................................................................ [ 86%]
........................................................................ [ 87%]
........................................................................ [ 87%]
........................................................................ [ 88%]
........................................................................ [ 88%]
........................................................................ [ 89%]
........................................................................ [ 89%]
........................................................................ [ 90%]
......................................................................... [ 90%]
........................................................................ [ 91%]
........................................................................ [ 91%]
.................................s...........ssss.s..................... [ 92%]
.........................s.......................x..........X........... [ 92%]
..X..........x........x...............X.x............................... [ 92%]
........................................................................ [ 93%]
........................................................................ [ 93%]
.....................................X.................................. [ 94%]
........................................................................ [ 94%]
........................................................................ [ 95%]
........................................................................ [ 95%]
........................................................................ [ 96%]
........................................................................ [ 96%]
........................................................................ [ 97%]
........................................................................ [ 97%]
........................................................................ [ 98%]
........................................................................ [ 98%]
........................................................................ [ 99%]
........................................................................ [ 99%]
..............................................................           [100%]


TOTAL                                                               6474   1475    77%

= 15233 passed, 32 skipped, 4 xfailed, 4 xpassed, 23896 warnings in 528.12s (0:08:48) =

@modin-bot
Copy link

modin-bot commented May 27, 2020 •
edited
Loading

TeamCity Ray test results bot

Tests PASSed

Tests Logs 
modin/pandas/test/test_io.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: xdist-1.32.0, forked-1.1.3, cov-2.9.0, custom-exit-code-0.3.0, testmon-1.0.2
collected 78 items

modin/pandas/test/test_io.py ...............s.........s................. [ 55%]
............s..s.X.....s........ss.                                      [100%]


TOTAL                                                               6474   3722    43%


============ 70 passed, 7 skipped, 1 xpassed, 72 warnings in 31.89s ============
Closing remaining open files:test_write_modin.hdf...donetest_write_pandas.hdf...done
-rfE --tb=native modin/experimental/pandas/test/test_io_exp.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: xdist-1.32.0, forked-1.1.3, cov-2.9.0, custom-exit-code-0.3.0, testmon-1.0.2
collected 2 items

modin/experimental/pandas/test/test_io_exp.py ..                         [100%]


TOTAL                                                               6474   3681    43%


======================== 2 passed, 3 warnings in 2.55s =========================
-rfE --tb=native -n=48 modin/pandas/test/test_series.py modin/pandas/test/test_dataframe.py modin/pandas/test/test_concat.py modin/pandas/test/test_groupby.py modin/pandas/test/test_reshape.py modin/pandas/test/test_general.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: xdist-1.32.0, forked-1.1.3, cov-2.9.0, custom-exit-code-0.3.0, testmon-1.0.2
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [15273] / gw1 [15273] / gw2 [15273] / gw3 [15273] / gw4 [15273] / gw5 [15273] / gw6 [15273] / gw7 [15273] / gw8 [15273] / gw9 [15273] / gw10 [15273] / gw11 [15273] / gw12 [15273] / gw13 [15273] / gw14 [15273] / gw15 [15273] / gw16 [15273] / gw17 [15273] / gw18 [15273] / gw19 [15273] / gw20 [15273] / gw21 [15273] / gw22 [15273] / gw23 [15273] / gw24 [15273] / gw25 [15273] / gw26 [15273] / gw27 [15273] / gw28 [15273] / gw29 [15273] / gw30 [15273] / gw31 [15273] / gw32 [15273] / gw33 [15273] / gw34 [15273] / gw35 [15273] / gw36 [15273] / gw37 [15273] / gw38 [15273] / gw39 [15273] / gw40 [15273] / gw41 [15273] / gw42 [15273] / gw43 [15273] / gw44 [15273] / gw45 [15273] / gw46 [15273] / gw47 [15273]

........................................................................ [  0%]
........................................................................ [  0%]
......................................................................... [  1%]
........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  2%]
........................................................................ [  3%]
.......................................................................... [  3%]
........................................................................ [  4%]
s........................................................................ [  4%]
........................................................................ [  5%]
.....................................s.................................. [  5%]
.........................s.............................................. [  6%]
........................................................................ [  6%]
........................................................................ [  7%]
........................................................................ [  7%]
........................................................................ [  8%]
........................................................................ [  8%]
.s...................................................................... [  8%]
......................................................................... [  9%]
................................s.......................................... [  9%]
.................................................................s...... [ 10%]
........................................................................ [ 10%]
........................................................................ [ 11%]
........................................................................ [ 11%]
........................................................................ [ 12%]
........................................................................ [ 12%]
........................................................................ [ 13%]
........................................................................ [ 13%]
........................................................................ [ 14%]
........................................................................ [ 14%]
........................................................................ [ 15%]
......................................................................... [ 15%]
........................................................................ [ 16%]
........................................................................ [ 16%]
........................................................................ [ 17%]
........................................................................ [ 17%]
........................................................................ [ 17%]
........................................................................ [ 18%]
........................................................................ [ 18%]
........................................................................ [ 19%]
......................................................................... [ 19%]
........................................................................ [ 20%]
..........................................s............................. [ 20%]
........................................................................ [ 21%]
........................................................................ [ 21%]
........................................................................ [ 22%]
........................................................................ [ 22%]
........................................................................ [ 23%]
........................................................................ [ 23%]
........................................................................ [ 24%]
........................................................................ [ 24%]
........................................................................ [ 25%]
........................................................................ [ 25%]
........................................................................ [ 25%]
........................................................................ [ 26%]
........................................................................ [ 26%]
........................................................................ [ 27%]
........................................................................ [ 27%]
.........................sssss.s.sssss.s................................ [ 28%]
........................................................................ [ 28%]
........................................................................ [ 29%]
........................................................................ [ 29%]
......................................................................... [ 30%]
........................................................................ [ 30%]
........................................................................ [ 31%]
......................................................................... [ 31%]
........................................................................ [ 32%]
........................................................................ [ 32%]
........................................................................ [ 33%]
......................................................................... [ 33%]
......................................................................... [ 34%]
................................ss..s.sss................................ [ 34%]
........................................................................ [ 34%]
........................................................................ [ 35%]
......................................................................... [ 35%]
........................................................................ [ 36%]
........................................................................ [ 36%]
........................................................................ [ 37%]
........................................................................ [ 37%]
........................................................................ [ 38%]
........................................................................ [ 38%]
........................................................................ [ 39%]
........................................................................ [ 39%]
........................................................................ [ 40%]
........................................................................ [ 40%]
........................................................................ [ 41%]
......................................................................... [ 41%]
........................................................................ [ 42%]
......................................................................... [ 42%]
........................................................................ [ 43%]
........................................................................ [ 43%]
........................................................................ [ 43%]
........................................................................ [ 44%]
........................................................................ [ 44%]
........................................................................ [ 45%]
........................................................................ [ 45%]
........................................................................ [ 46%]
........................................................................ [ 46%]
........................................................................ [ 47%]
........................................................................ [ 47%]
........................................................................ [ 48%]
......................................................................... [ 48%]
........................................................................ [ 49%]
........................................................................ [ 49%]
........................................................................ [ 50%]
........................................................................ [ 50%]
........................................................................ [ 51%]
........................................................................ [ 51%]
........................................................................ [ 51%]
........................................................................ [ 52%]
........................................................................ [ 52%]
........................................................................ [ 53%]
........................................................................ [ 53%]
........................................................................ [ 54%]
........................................................................ [ 54%]
........................................................................ [ 55%]
........................................................................ [ 55%]
......................................................................... [ 56%]
........................................................................ [ 56%]
......................................................................... [ 57%]
........................................................................ [ 57%]
........................................................................ [ 58%]
........................................................................ [ 58%]
........................................................................ [ 59%]
........................................................................ [ 59%]
......................................................................... [ 60%]
........................................................................ [ 60%]
......................................................................... [ 60%]
........................................................................ [ 61%]
........................................................................ [ 61%]
........................................................................ [ 62%]
........................................................................ [ 62%]
........................................................................ [ 63%]
........................................................................ [ 63%]
........................................................................ [ 64%]
........................................................................ [ 64%]
.......................................................................... [ 65%]
........................................................................ [ 65%]
........................................................................ [ 66%]
......................................................................... [ 66%]
........................................................................ [ 67%]
........................................................................ [ 67%]
........................................................................ [ 68%]
........................................................................ [ 68%]
........................................................................ [ 68%]
........................................................................ [ 69%]
........................................................................ [ 69%]
........................................................................ [ 70%]
........................................................................ [ 70%]
......................................................................... [ 71%]
........................................................................ [ 71%]
........................................................................ [ 72%]
......................................................................... [ 72%]
........................................................................ [ 73%]
........................................................................ [ 73%]
........................................................................ [ 74%]
......................................................................... [ 74%]
........................................................................ [ 75%]
........................................................................ [ 75%]
........................................................................ [ 76%]
........................................................................ [ 76%]
........................................................................ [ 77%]
........................................................................ [ 77%]
........................................................................ [ 77%]
........................................................................ [ 78%]
........................................................................ [ 78%]
........................................................................ [ 79%]
........................................................................ [ 79%]
........................................................................ [ 80%]
........................................................................ [ 80%]
........................................................................ [ 81%]
........................................................................ [ 81%]
........................................................................ [ 82%]
........................................................................ [ 82%]
......................................................................... [ 83%]
........................................................................ [ 83%]
........................................................................ [ 84%]
........................................................................ [ 84%]
........................................................................ [ 85%]
........................................................................ [ 85%]
......................................................................... [ 85%]
........................................................................ [ 86%]
........................................................................ [ 86%]
......................................................................... [ 87%]
........................................................................ [ 87%]
........................................................................ [ 88%]
........................................................................ [ 88%]
........................................................................ [ 89%]
........................................................................ [ 89%]
........................................................................ [ 90%]
......................................................................... [ 90%]
.....................................................sss.s.s............ [ 91%]
.......................s................................................ [ 91%]
.......................................................................x. [ 92%]
.X..........x.....X.X..x...x....X....................................... [ 92%]
............................................s........................... [ 93%]
........................................................................ [ 93%]
........................................................................ [ 94%]
......................................................................... [ 94%]
........................................................................ [ 94%]
........................................................................ [ 95%]
........................................................................ [ 95%]
........................................................................ [ 96%]
........................................................................ [ 96%]
........................................................................ [ 97%]
........................................................................ [ 97%]
........................................................................ [ 98%]
........................................................................ [ 98%]
........................................................................ [ 99%]
........................................................................ [ 99%]
..............................................                           [100%]


TOTAL                                                               6474   1160    82%

= 15233 passed, 32 skipped, 4 xfailed, 4 xpassed, 23987 warnings in 693.23s (0:11:33) =

@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #1495 into master will increase coverage by 2.81%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
+ Coverage   83.46%   86.28%   +2.81%     
==========================================
  Files          68       68              
  Lines        6473     6474       +1     
==========================================
+ Hits         5403     5586     +183     
+ Misses       1070      888     -182
Impacted Files Coverage Δ
modin/pandas/dataframe.py 88.17% <92.30%> (+0.01%) ⬆️
modin/pandas/series.py 92.73% <0.00%> (+0.13%) ⬆️
modin/pandas/__init__.py 80.00% <0.00%> (+1.42%) ⬆️
modin/engines/base/frame/data.py 94.14% <0.00%> (+1.46%) ⬆️
modin/backends/pandas/parsers.py 57.14% <0.00%> (+2.04%) ⬆️
modin/engines/base/frame/partition_manager.py 86.75% <0.00%> (+6.62%) ⬆️
modin/backends/pandas/query_compiler.py 94.40% <0.00%> (+14.00%) ⬆️
modin/engines/base/io/io.py 94.11% <0.00%> (+18.62%) ⬆️
...es/python/pandas_on_python/frame/axis_partition.py 100.00% <0.00%> (+21.42%) ⬆️
modin/engines/base/frame/axis_partition.py 77.77% <0.00%> (+40.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4286305...18e2556. Read the comment docs.

@modin-bot
Copy link

modin-bot commented May 27, 2020 •
edited
Loading

TeamCity Dask test results bot

Tests PASSed

Tests Logs 
-rfE --tb=native modin/pandas/test/test_io.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: testmon-1.0.2, cov-2.9.0, forked-1.1.3, custom-exit-code-0.3.0, xdist-1.32.0
collected 78 items

modin/pandas/test/test_io.py ...............s.........s................. [ 55%]
............s..s.X.....s........ss.                                      [100%]


TOTAL                                                               6474   3800    41%


============ 70 passed, 7 skipped, 1 xpassed, 74 warnings in 35.70s ============
Closing remaining open files:test_write_pandas.hdf...donetest_write_modin.hdf...done
-rfE --tb=native -n=48 modin/pandas/test/test_series.py modin/pandas/test/test_dataframe.py modin/pandas/test/test_concat.py modin/pandas/test/test_groupby.py modin/pandas/test/test_reshape.py modin/pandas/test/test_general.py
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-5.4.2, py-1.8.1, pluggy-0.13.1
rootdir: /localdisk/tc_agent/work/199b2674cba60ed6, inifile: setup.cfg
plugins: testmon-1.0.2, cov-2.9.0, forked-1.1.3, custom-exit-code-0.3.0, xdist-1.32.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [15273] / gw1 [15273] / gw2 [15273] / gw3 [15273] / gw4 [15273] / gw5 [15273] / gw6 [15273] / gw7 [15273] / gw8 [15273] / gw9 [15273] / gw10 [15273] / gw11 [15273] / gw12 [15273] / gw13 [15273] / gw14 [15273] / gw15 [15273] / gw16 [15273] / gw17 [15273] / gw18 [15273] / gw19 [15273] / gw20 [15273] / gw21 [15273] / gw22 [15273] / gw23 [15273] / gw24 [15273] / gw25 [15273] / gw26 [15273] / gw27 [15273] / gw28 [15273] / gw29 [15273] / gw30 [15273] / gw31 [15273] / gw32 [15273] / gw33 [15273] / gw34 [15273] / gw35 [15273] / gw36 [15273] / gw37 [15273] / gw38 [15273] / gw39 [15273] / gw40 [15273] / gw41 [15273] / gw42 [15273] / gw43 [15273] / gw44 [15273] / gw45 [15273] / gw46 [15273] / gw47 [15273]

........................................................................ [  0%]
........................................................................ [  0%]
........................................................................ [  1%]
........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  2%]
........................................................................ [  3%]
......................................................................... [  3%]
........................................................................ [  4%]
...................................................................s.... [  4%]
........................................................................ [  5%]
.........................................s......s....................... [  5%]
........................................................................ [  6%]
........................................................................ [  6%]
......................................................................... [  7%]
........................................................................ [  7%]
.......................................................s................ [  8%]
........................................................................ [  8%]
............................................s............................ [  8%]
........................................................................ [  9%]
........................................................................ [  9%]
........................................................................ [ 10%]
......................................................................... [ 10%]
........................................................................ [ 11%]
..................s..................................................... [ 11%]
........................................................................ [ 12%]
........................................................................ [ 12%]
........................................................................ [ 13%]
........................................................................ [ 13%]
........................................................................ [ 14%]
........................................................................ [ 14%]
........................................................................ [ 15%]
........................................................................ [ 15%]
........................................................................ [ 16%]
........................................................................ [ 16%]
........................................................................ [ 16%]
........................................................................ [ 17%]
........................................................................ [ 17%]
........................................................................ [ 18%]
........................................................................ [ 18%]
........................................................................ [ 19%]
........................................................................ [ 19%]
........................................................................ [ 20%]
......s................................................................. [ 20%]
......................................................................... [ 21%]
........................................................................ [ 21%]
........................................................................ [ 22%]
........................................................................ [ 22%]
........................................................................ [ 23%]
........................................................................ [ 23%]
........................................................................ [ 24%]
........................................................................ [ 24%]
........................................................................ [ 25%]
........................................................................ [ 25%]
........................................................................ [ 25%]
........................................................................ [ 26%]
........................................................................ [ 26%]
........................................................................ [ 27%]
........................................................................ [ 27%]
........................................................................ [ 28%]
........................................................................ [ 28%]
...........................................................ssss.ssssss.. [ 29%]
sssssss.s............................................................... [ 29%]
........................................................................ [ 30%]
........................................................................ [ 30%]
........................................................................ [ 31%]
......................................................................... [ 31%]
........................................................................ [ 32%]
........................................................................ [ 32%]
........................................................................ [ 33%]
........................................................................ [ 33%]
........................................................................ [ 33%]
........................................................................ [ 34%]
......................................................................... [ 34%]
........................................................................ [ 35%]
........................................................................ [ 35%]
........................................................................ [ 36%]
........................................................................ [ 36%]
........................................................................ [ 37%]
........................................................................ [ 37%]
........................................................................ [ 38%]
........................................................................ [ 38%]
......................................................................... [ 39%]
........................................................................ [ 39%]
......................................................................... [ 40%]
........................................................................ [ 40%]
........................................................................ [ 41%]
........................................................................ [ 41%]
........................................................................ [ 42%]
........................................................................ [ 42%]
........................................................................ [ 42%]
........................................................................ [ 43%]
........................................................................ [ 43%]
........................................................................ [ 44%]
........................................................................ [ 44%]
........................................................................ [ 45%]
........................................................................ [ 45%]
........................................................................ [ 46%]
........................................................................ [ 46%]
.......................................................................... [ 47%]
........................................................................ [ 47%]
........................................................................ [ 48%]
........................................................................ [ 48%]
........................................................................ [ 49%]
........................................................................ [ 49%]
........................................................................ [ 50%]
........................................................................ [ 50%]
........................................................................ [ 50%]
........................................................................ [ 51%]
........................................................................ [ 51%]
........................................................................ [ 52%]
........................................................................ [ 52%]
........................................................................ [ 53%]
........................................................................ [ 53%]
........................................................................ [ 54%]
........................................................................ [ 54%]
........................................................................ [ 55%]
........................................................................ [ 55%]
........................................................................ [ 56%]
......................................................................... [ 56%]
........................................................................ [ 57%]
........................................................................ [ 57%]
........................................................................ [ 58%]
........................................................................ [ 58%]
........................................................................ [ 59%]
........................................................................ [ 59%]
........................................................................ [ 59%]
........................................................................ [ 60%]
........................................................................ [ 60%]
........................................................................ [ 61%]
........................................................................ [ 61%]
........................................................................ [ 62%]
........................................................................ [ 62%]
........................................................................ [ 63%]
......................................................................... [ 63%]
........................................................................ [ 64%]
........................................................................ [ 64%]
........................................................................ [ 65%]
........................................................................ [ 65%]
........................................................................ [ 66%]
........................................................................ [ 66%]
........................................................................ [ 67%]
......................................................................... [ 67%]
........................................................................ [ 67%]
........................................................................ [ 68%]
........................................................................ [ 68%]
........................................................................ [ 69%]
........................................................................ [ 69%]
........................................................................ [ 70%]
........................................................................ [ 70%]
........................................................................ [ 71%]
........................................................................ [ 71%]
........................................................................ [ 72%]
........................................................................ [ 72%]
........................................................................ [ 73%]
........................................................................ [ 73%]
......................................................................... [ 74%]
........................................................................ [ 74%]
........................................................................ [ 75%]
........................................................................ [ 75%]
........................................................................ [ 75%]
........................................................................ [ 76%]
........................................................................ [ 76%]
........................................................................ [ 77%]
......................................................................... [ 77%]
........................................................................ [ 78%]
........................................................................ [ 78%]
........................................................................ [ 79%]
........................................................................ [ 79%]
........................................................................ [ 80%]
........................................................................ [ 80%]
......................................................................... [ 81%]
........................................................................ [ 81%]
........................................................................ [ 82%]
........................................................................ [ 82%]
........................................................................ [ 83%]
........................................................................ [ 83%]
........................................................................ [ 84%]
........................................................................ [ 84%]
........................................................................ [ 84%]
........................................................................ [ 85%]
......................................................................... [ 85%]
........................................................................ [ 86%]
........................................................................ [ 86%]
........................................................................ [ 87%]
........................................................................ [ 87%]
........................................................................ [ 88%]
........................................................................ [ 88%]
......................................................................... [ 89%]
........................................................................ [ 89%]
......................................................................... [ 90%]
........................................................................ [ 90%]
........................................................................ [ 91%]
....................................s..s................................ [ 91%]
........................................................................ [ 92%]
....................................X.......x......x........X......X.... [ 92%]
.....x..x....s..........s.s.ss.......................................... [ 93%]
........................................................................ [ 93%]
........................................................................ [ 93%]
........................................................................ [ 94%]
........................................................................ [ 94%]
........................................................................ [ 95%]
........................................................................ [ 95%]
........................................................................ [ 96%]
........................................................................ [ 96%]
........................................................................ [ 97%]
........................................................................ [ 97%]
........................................................................ [ 98%]
................................................X....................... [ 98%]
........................................................................ [ 99%]
........................................................................ [ 99%]
.............................................................            [100%]


TOTAL                                                               6474   1256    81%

= 15233 passed, 32 skipped, 4 xfailed, 4 xpassed, 23986 warnings in 780.69s (0:13:00) =

devin-petersohn
devin-petersohn requested changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @gshimansky, there was an extra newline added.

@gshimansky @devin-petersohn
Remove extra new line in modin/pandas/dataframe.py
18e2556 
Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
@gshimansky gshimansky merged commit 564e6cc into modin-project:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gshimansky @modin-bot @devin-petersohn