Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: add query compiler interfaces for some string methods #6063

Closed
mvashishtha opened this issue May 1, 2023 · 2 comments · Fixed by #6088
Closed

REFACTOR: add query compiler interfaces for some string methods #6063

mvashishtha opened this issue May 1, 2023 · 2 comments · Fixed by #6088
Assignees
@mvashishtha
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests ponder modin work desired for the ponder product

Comments

@mvashishtha
Copy link
Collaborator

@mvashishtha mvashishtha added Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests labels May 1, 2023
@mvashishtha mvashishtha self-assigned this May 1, 2023
@mvashishtha
Copy link
Collaborator Author

mvashishtha commented May 3, 2023 •
edited
Loading

It turns out that someone has already added day_of_year and day_of_week.

@mvashishtha
Copy link
Collaborator Author

methods in series_utils here have already been added: ponder-org@c271c92#diff-890c48e6da7113aa9bdb7e7f9e219d21ea51fa1b550fb02327fca8738b2da54a

@mvashishtha mvashishtha changed the title REFACTOR: add query compiler interfaces for some string and datetime methods REFACTOR: add query compiler interfaces for some string methods May 3, 2023
mvashishtha pushed a commit to mvashishtha/modin that referenced this issue May 4, 2023
REFACTOR-modin-project#6063: Add query compiler interfaces for some s…
91132b1 
…trings methods.

Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha mentioned this issue May 4, 2023
Merged
7 tasks
RehanSD pushed a commit that referenced this issue May 4, 2023
@mvashishtha
REFACTOR-#6063: Add query compiler interfaces for some strings method…
cf9e7fc 
…s. (#6088)

Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha mvashishtha added the ponder modin work desired for the ponder product label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvashishtha mvashishtha

Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests ponder modin work desired for the ponder product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#6063: Add query compiler interfaces for some strings methods. mvashishtha/modin
1 participant
@mvashishtha