Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting self.resample_args for Resampler into a dict #3724

Closed
Rubtsowa opened this issue Nov 22, 2021 · 0 comments · Fixed by #3738
Closed

Converting self.resample_args for Resampler into a dict #3724

Rubtsowa opened this issue Nov 22, 2021 · 0 comments · Fixed by #3738

Comments

@Rubtsowa
Copy link
Contributor

self.resample_args for Resampler should be converted into a dict to ensure simplicity of handling resample parameters at the query compiler level.
@Rubtsowa Rubtsowa changed the title Converting self.resample_args into a dict Converting self.resample_args for Resampler into a dict Nov 22, 2021
@Rubtsowa Rubtsowa mentioned this issue Nov 22, 2021
Merged
7 tasks
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 25, 2021
@Rubtsowa
FEAT-modin-project#3724: Converting self.resample_args for Resampler …
34d0a23 
…into a dict

Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
@Rubtsowa Rubtsowa mentioned this issue Nov 25, 2021
Merged
7 tasks
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 25, 2021
@Rubtsowa
FEAT-modin-project#3724: Rename resample_args on resample_kwargs
cf900d6 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 26, 2021
@Rubtsowa
FEAT-modin-project#3724: Delete not neeeded comment
6ee9246 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
YarShev pushed a commit that referenced this issue Nov 29, 2021
@Rubtsowa
FEAT-#3724: Converting self.resample_args for Resampler into a dict (#…
d8963a6 
…3738)

Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#3724: Converting self.resample_args for Resampler into a dict Rubtsowa/modin
1 participant
@Rubtsowa