Skip to content

Implement a maximum pandas compatibility mode #3411

@gshimansky

Description

@gshimansky

Some recent PRs introduced known difference in behavior between Modin and Pandas. I know of at least two:

  1. Different order of columns in groupby.__getitem__ FIX-#3252: Fix GroupBy.__getitem__ #3298 (comment)
  2. Index instead of MultiIndex in DataFrame.value_counts FIX-#1294: fixed 'value_counts' implementation #2730 (comment)

Workarounds for differences in both cases above are trivial but impair performance. I suggest to add a setting called something like MODIN_MAXIMUM_PANDAS_COMPAT that would implement workarounds at the expense of performance and make functions behavior in the closest possible way to how Pandas implements them. In case some user's application breaks when he replaces import pandas with import modin.pandas such setting would allow to quickly fix problems that happen because of incompatibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Very minor bugs, or features we can hopefully add some day.new feature/request 💬Requests and pull requests for new features

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions