Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modin resample error #3303

Closed
kocmurat93 opened this issue Aug 3, 2021 · 6 comments · Fixed by #3613
Closed

Modin resample error #3303

kocmurat93 opened this issue Aug 3, 2021 · 6 comments · Fixed by #3613
Assignees
@Rubtsowa
Labels
Backport 🔙 Issues that need to be backported to previous release(s) bug 🦗 Something isn't working External Pull requests and issues from people who do not regularly contribute to modin P0 Highest priority tasks requiring immediate fix

Comments

@kocmurat93
Copy link

hi ,
i used resample method with ray modin and ı got error that was TypeError: ‘Resampler’ object is not subscriptable . My code works with pandas .
my code is :
team_md.resample(‘3T’)[[‘Value’]].mean()
how can i solve this ?

thanks !

Murat KOÇ
Machine Learning Engineer
@kocmurat93 kocmurat93 added the bug 🦗 Something isn't working label Aug 3, 2021
@prutskov
Copy link
Contributor

prutskov commented Aug 3, 2021

Hi, @kocmurat93!
Thank you for the report. Looks like Resampler object hasn't __getitem__ method, that's reason of your issue. This is bug and we will fix that.

@prutskov prutskov self-assigned this Aug 3, 2021
@kocmurat93
Copy link
Author

hi @prutskov ,

We would like to help you to fix the bug in order to speed up the process . Our team can fix this bug.

@prutskov
Copy link
Contributor

prutskov commented Aug 3, 2021

@kocmurat93 it would be great! Before creating of corresponded PR, please, note about our contributing guidelines.

@dikuchan
Copy link

dikuchan commented Sep 14, 2021 •
edited
Loading

@prutskov Hi! What's the current status of the issue? I may try to fix the bug if it's not that complex.

@devin-petersohn
Copy link
Collaborator

@dikuchan Please feel free to make the change, it is fairly straightforward.

@prutskov Are you able to assist here as well?

@prutskov
Copy link
Contributor

@devin-petersohn Yes, sure, I'll help.
@dikuchan If you have any questions feel free to ask! Note about our contributing guidelines.

@Garra1980 Garra1980 assigned Rubtsowa and unassigned prutskov Oct 6, 2021
@devin-petersohn devin-petersohn added P0 Highest priority tasks requiring immediate fix P1 Important tasks that we should complete soon and removed P1 Important tasks that we should complete soon labels Oct 14, 2021
@prutskov prutskov mentioned this issue Nov 22, 2021
Merged
7 tasks
@Garra1980 Garra1980 added the External Pull requests and issues from people who do not regularly contribute to modin label Nov 23, 2021
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Add __getitem__ for Resampler
8a36be2 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Deleted not needed list construction.
017e949 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Changed tests.
e5ee6d2 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Changed tests.
da487a2 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Changed test and impl
4cfcf46 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Changed impl
21a6fda 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Deleted slice in msg about error
e0f9e75 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa pushed a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@prutskov @Rubtsowa
FIX-modin-project#3303: Align __getitem__ impl with pandas, additio…
26a3f49 
…nal tests

Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Add test and change impl
03f78f9 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Remove unnecessary elements
1efafca 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Change name of parameter in test
ec04f9e 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Rubtsowa added a commit to Rubtsowa/modin that referenced this issue Nov 23, 2021
@Rubtsowa
FEAT-modin-project#3303: Change msg of error
947aa9e 
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
YarShev pushed a commit that referenced this issue Nov 25, 2021
@Rubtsowa @prutskov
FEAT-#3303: Add __getitem__ for Resampler (#3613)
1a1edfd 
Co-authored-by: Alexey Prutskov <alexey.prutskov@intel.com>
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
@devin-petersohn devin-petersohn added the Backport 🔙 Issues that need to be backported to previous release(s) label Dec 6, 2021
devin-petersohn pushed a commit that referenced this issue Dec 15, 2021
@Rubtsowa @prutskov @devin-petersohn
FEAT-#3303: Add __getitem__ for Resampler (#3613)
c0728a9 
Co-authored-by: Alexey Prutskov <alexey.prutskov@intel.com>
Signed-off-by: Maria Rubtsova <maria.rubtsova@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubtsowa Rubtsowa

Labels
Backport 🔙 Issues that need to be backported to previous release(s) bug 🦗 Something isn't working External Pull requests and issues from people who do not regularly contribute to modin P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#3303: Add __getitem__ for Resampler Rubtsowa/modin
6 participants
@devin-petersohn @kocmurat93 @Garra1980 @prutskov @dikuchan @Rubtsowa