Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support returning multiple values from _apply_full_axis #2214

Closed
YarShev opened this issue Oct 5, 2020 · 3 comments
Closed

Support returning multiple values from _apply_full_axis #2214

YarShev opened this issue Oct 5, 2020 · 3 comments
Assignees
@YarShev
Labels
new feature/request 💬 Requests and pull requests for new features

Comments

@YarShev
Copy link
Collaborator

YarShev commented Oct 5, 2020

No description provided.

@YarShev YarShev added the new feature/request 💬 Requests and pull requests for new features label Oct 5, 2020
@YarShev YarShev self-assigned this Oct 5, 2020
@devin-petersohn
Copy link
Collaborator

What is the need for this?

@YarShev
Copy link
Collaborator Author

YarShev commented Oct 12, 2020

This is request from oneDAL team. They are currently implementing some prototype for their distributed algorithms with using Modin, namely, _apply_full_axis. In order to be compatible with scikit-learn they asked us to implement returning of multiple values from _apply_full_axis. I think this feature is useful for us as well because there are some functions (like pandas.DataFrame.align) which return multiple values. I have already provided the feature related to returning of multiple values from _apply_full_axis to oneDAL team and currently I am doing pd.DataFrame.align implementation.

@YarShev YarShev mentioned this issue Oct 16, 2020
Closed
6 tasks
YarShev added a commit to YarShev/modin that referenced this issue Nov 9, 2020
@YarShev
FEAT-modin-project#2214, FEAT-modin-project#1233, FEAT-modin-project#…
9c1e14d 
…1185: Add `align` implementation

for `DataFrame` and `Series`

Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
@YarShev
Copy link
Collaborator Author

YarShev commented Jan 13, 2021

I am closing the issue because we implemented another approach for distributed ML algorithms.
Having tested the performance for aling method with the feature of returning multiple values from _apply_full_axis it turned out the execution time of Modin implementation is significantly more than pandas. We will need to think of another implementation for align.

@YarShev YarShev closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YarShev YarShev

Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#2214, FEAT-#1233, FEAT-#1185: Add align implementation for DataFrame and Series YarShev/modin
2 participants
@devin-petersohn @YarShev