Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modin Pandas concat with axis=1 does not work #1700

Closed
pashkov-v opened this issue Jul 9, 2020 · 1 comment · Fixed by #1797
Closed

Modin Pandas concat with axis=1 does not work #1700

pashkov-v opened this issue Jul 9, 2020 · 1 comment · Fixed by #1797
Assignees
Labels
bug 🦗 Something isn't working
Milestone

Comments

@pashkov-v
Copy link

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.4 LTS
  • Modin version (modin.__version__): 0.7.4
  • Python version: 3.8.0

Describe the problem

When I try to concatenate several Modin Pandas DataFrames of equal number of rows column-wise, I get either KeyError: 'Passing list-likes to .loc or [] with any missing labels is no longer supported, see https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#deprecate-loc-reindex-listlike' (when ignore_index=False), or ValueError: Length mismatch: (with ignore_index=True).

Source code / logs

import numpy as np
import modin.pandas as modin_pd
modin_pd.concat([modin_pd.Series(np.ones(10)), modin_pd.Series(np.ones(10))], axis=1, ignore_index=True)
@pashkov-v pashkov-v added the bug 🦗 Something isn't working label Jul 9, 2020
@devin-petersohn
Copy link
Collaborator

Hi @pashkov-v thanks for the report!

I can reproduce this with the code you provided on current master branch. It looks like a metadata issue at the API layer because _to_pandas on the result produces a correct result.

import numpy as np
import modin.pandas as modin_pd
modin_pd.concat([modin_pd.Series(np.ones(10)), modin_pd.Series(np.ones(10))], axis=1, ignore_index=True)._to_pandas()

@devin-petersohn devin-petersohn added this to the 0.8.0 milestone Jul 10, 2020
@devin-petersohn devin-petersohn self-assigned this Jul 24, 2020
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jul 24, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit that referenced this issue Jul 24, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
modin-project#1797)

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants