Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cummax/cummin throw exception on mixed int/float type dataframes #1467

Closed
gshimansky opened this issue May 20, 2020 · 1 comment · Fixed by #1800
Closed

cummax/cummin throw exception on mixed int/float type dataframes #1467

gshimansky opened this issue May 20, 2020 · 1 comment · Fixed by #1800
Assignees
Labels
bug 🦗 Something isn't working
Milestone

Comments

@gshimansky
Copy link
Collaborator

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

Ubuntu 19.10

  • Modin version (modin.__version__):

0.7.3+42.gc78828e.dirty

  • Python version:

Python 3.7.5

  • Code we can use to reproduce:
import modin.pandas as pd

data={'col1': [1, 2], 'col2': [3.3, 4.4]}
df = pd.DataFrame(data)
df1 = df.cummax(axis=1)
print(df1)

Describe the problem

Pandas allows comparing ints with floats while Modin throws a TypeException.

Source code / logs

@gshimansky gshimansky added the bug 🦗 Something isn't working label May 20, 2020
gshimansky added a commit to gshimansky/modin that referenced this issue May 20, 2020
Fixed cummin/cummax and quantile functions to work correctly.

Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com>
@devin-petersohn
Copy link
Collaborator

The same problem exists for cummin.

@devin-petersohn devin-petersohn self-assigned this Jul 24, 2020
@devin-petersohn devin-petersohn added this to the 0.8.0 milestone Jul 24, 2020
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jul 24, 2020
…and float

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit that referenced this issue Jul 24, 2020
)

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
…and float (modin-project#1800)

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants