fix(rust-codegen): emit nested service struct definitions #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `subServiceContent.push(subService.content)` in rustServiceFromSchema to include nested service struct definitions in the generated output. Fixes modiimedia#187
Member
|
Thanks for opening this. LGTM. I'm going to open a separate PR that includes nested subservices in our integration test suite so that all language generators get tested for this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
subServiceContent.push(subService.content)inrustServiceFromSchemato include nested service struct definitions in the generated outputProblem
When using nested service namespaces (e.g.,
v1.updates,v1.registry), the generated Rust code references child service types but never defines them, causing compilation errors.Fixes #187