Skip to content

try object arrays for perioddata #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

wpbonelli
Copy link
Member

up to now the prototype has separated period data into an array for each column of the period data record (OC is a little different but same spirit). this makes unstructuring/writing to input files harder because the arrays must be recombined or cleverly indexed, and it also departs from the DFN files, which will mean we need some extra translations during codegen. try following the DFNs exactly and using arrays of object dtype. this makes indexing/etc a little more awkward. hope this helps us consider the tradeoffs and decide which approach is ideal.

@wpbonelli
Copy link
Member Author

Despite the challenges this presents in transformation before writing MF6 list-based input, it seems best to keep array variables separate. The fact that they are combined as records in the DFN specification is a formatting detail, not a core requirement.

@wpbonelli wpbonelli closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant