Skip to content

refactor(FlopyBinaryData): use properties, deprecate set_float #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

wpbonelli
Copy link
Member

Minor cleanup. Use properties instead of attributes. Deprecate set_float() and replace usages with precision setter.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (bb9824e) to head (42f6b71).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/utils_def.py 90.2% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2421     +/-   ##
=========================================
+ Coverage     68.4%   76.3%   +7.8%     
=========================================
  Files          294     294             
  Lines        59390   59855    +465     
=========================================
+ Hits         40652   45690   +5038     
+ Misses       18738   14165   -4573     
Files with missing lines Coverage Δ
flopy/mf6/utils/binarygrid_util.py 92.2% <100.0%> (+0.3%) ⬆️
flopy/utils/observationfile.py 89.0% <100.0%> (+0.1%) ⬆️
flopy/utils/swroutputfile.py 96.1% <100.0%> (+<0.1%) ⬆️
flopy/utils/utils_def.py 85.9% <90.2%> (+5.7%) ⬆️

... and 244 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review January 20, 2025 14:56
@wpbonelli wpbonelli merged commit ef5ca6a into modflowpy:develop Jan 20, 2025
23 checks passed
@wpbonelli wpbonelli deleted the binarygrid_util branch January 20, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant