Skip to content

fix(regression): corrections to test_create_tests_transport #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Jun 13, 2024

While this regression test "passes", this PR resolves two errors to actually compare concentrations results:

  1. Fix typo for filename "gwt_mst03.unc" ->"gwt_mst03.ucn"
  2. Compare the two concentration files with compare_heads with text="concentration".

Further explanations to the fixes:

  1. The flopy.utils.compare module "passes" (returns assert True) if there are there are not two files to compare, which is an unusually silent approach. This was due to the filename typo.
  2. These files are not MT3D-style concentration files, and would raise exceptions if read with UcnFile. They must be read with HeadFile(..., text="concentration")

@wpbonelli wpbonelli merged commit c69990a into modflowpy:develop Jun 13, 2024
@mwtoews mwtoews deleted the fix-regression-transport branch June 13, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants