Remove code comments when extracting variables. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfinite loop in extractContextVariableNames due to braces being inside comments and counts not matching
|
This problem was came up for me with \\ comments, but this solution will work for /* */ comments.
Was the formula that presented the problem for me, for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an infinite loop in extractContextVariableNames due to braces being inside comments and counts not matching.
I know you had a solution you were working on, but this worked for me when trying to get around this problem for an app I've been using for DevOps Pipeliness testing. So just throwing it in the pot if it gets you any closer to a solution :)
This relates to findClosingCharacter never returns and possibly MSAPP file processing not completing