Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set node version to 18 #2394

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

koddsson
Copy link
Contributor

What I did

  1. I set engines.node version to at least 18.

I figured since we aren't even testing on node16 that we don't actually support it.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: c185cba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@web/rollup-plugin-import-meta-assets Minor
@web/rollup-plugin-polyfills-loader Minor
@web/test-runner-visual-regression Minor
@web/test-runner-junit-reporter Minor
@web/test-runner-browserstack Minor
@web/test-runner-coverage-v8 Minor
@web/dev-server-import-maps Minor
@web/test-runner-playwright Minor
@web/test-runner-puppeteer Minor
@web/test-runner-saucelabs Minor
@web/test-runner-webdriver Minor
@web/dev-server-storybook Minor
@web/test-runner-commands Minor
@web/test-runner-selenium Minor
@web/dev-server-esbuild Minor
@web/rollup-plugin-copy Minor
@web/rollup-plugin-html Minor
@web/test-runner-chrome Minor
@web/dev-server-legacy Minor
@web/dev-server-rollup Minor
@web/test-runner-mocha Minor
@web/polyfills-loader Minor
@web/test-runner-core Minor
@web/dev-server-core Minor
@web/test-runner-cli Minor
@web/dev-server-hmr Minor
@web/config-loader Minor
@web/browser-logs Minor
@web/parse5-utils Minor
@web/test-runner Minor
@web/dev-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson force-pushed the set-node-engines-to-node-18 branch from 4ef722e to a3e3004 Compare July 19, 2023 07:50
@koddsson koddsson marked this pull request as ready for review July 19, 2023 08:06
@koddsson
Copy link
Contributor Author

Would this be all breaking changes? 🤔

@bashmish
Copy link
Member

Would this be all breaking changes? 🤔

Theoretically. But for pragmatic reasons I'd keep it a patch

Copy link
Member

@bashmish bashmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me indeed!

@koddsson
Copy link
Contributor Author

Makes sense to me indeed!

Nice! I'll update the versions to be a minor bump and if no one else chimes in soon I'll release this 👍🏻

@koddsson koddsson merged commit d0079c6 into modernweb-dev:master Nov 1, 2023
@koddsson koddsson deleted the set-node-engines-to-node-18 branch November 1, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants