fix(rollup-plugin-import-meta-assets): completely overwrite import.meta.url #1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the duplicated
import.meta.url
in the output, like this:Why
This way, it should work exactly the same (Rollup makes sure we have
import.meta.url
or something similar to base our URL on); but the secondimport.meta
gets eliminated, which reduces size, repetition, and most of all, doesn't trigger an error in Common JS modules.What I did
Updated the overwrite function
Updated tests