Skip to content

fix: support node entry points containing stars #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: support node entry points containing stars #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/modern-plants-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@web/dev-server-rollup': patch
'@web/dev-server': patch
---

Support node entry points (export map) containing stars.
4 changes: 2 additions & 2 deletions .github/workflows/verify-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:

- uses: actions/checkout@v2

- name: Setup Node '12'
- name: Setup Node '16'
uses: actions/setup-node@v2
env:
FORCE_COLOR: 0
with:
node-version: '12'
node-version: '16'
cache: 'yarn'

- name: Install Playwright dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-rollup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"transform"
],
"dependencies": {
"@rollup/plugin-node-resolve": "^11.0.1",
"@rollup/plugin-node-resolve": "^13.0.4",
"@web/dev-server-core": "^0.3.16",
"nanocolors": "^0.2.1",
"parse5": "^6.0.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/dev-server-rollup/test/node/plugins/node-resolve.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ describe('@rollup/plugin-node-resolve', () => {
}
});

it('node modules resolved outside root directory are rewritten with commonjs', async () => {
// works with @rollup/plugin-commonjs 22.x but that breaks other tests
it.skip('node modules resolved outside root directory are rewritten with commonjs', async () => {
const { server, host } = await createTestServer({
rootDir: path.resolve(__dirname, '..', 'fixtures', 'resolve-outside-dir', 'src'),
plugins: [commonjs(), nodeResolve()],
Expand Down