Skip to content

refactor: replace chalk with nanocolors #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

web-padawan
Copy link
Contributor

What I did

  1. Replaced all chalk usage with the new nanocolors library.

See their README for some benefits: https://github.com/ai/nanocolors/tree/main#nano-colors

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2021

🦋 Changeset detected

Latest commit: e231add

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web/dev-server Patch
@web/dev-server-core Patch
@web/dev-server-rollup Patch
@web/test-runner Patch
@web/test-runner-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...but, not CI. Clear that up and happy to reapprove.

@Westbrook Westbrook self-requested a review September 22, 2021 16:16
@web-padawan
Copy link
Contributor Author

Thanks, for some reason the git hook didn't work 🤔

@web-padawan web-padawan requested review from daKmoR and LarsDenBakker and removed request for daKmoR and Westbrook September 22, 2021 16:54
@web-padawan web-padawan removed the request for review from LarsDenBakker September 24, 2021 14:18
@web-padawan web-padawan merged commit a09282b into master Sep 24, 2021
@web-padawan web-padawan deleted the refactor/nanocolors branch September 24, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants