[RFC] feat(test-runner-visual-regression): make "update" strict and add "buildCache" for more repeatable tests #1339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
update
property in the VRT config "strict". It will no only update if set to true, allowing newly added regressions (tests without a baseline) to fail the test pass.buildCache
property to the VRT config. This has the test save all of the current test output in one place so that it is easier to create a new cache from updated tests listings, including when tests have been intentionally removed.Questions
update
strictly means that a user with new screenshots can't add those shots while testing if existing tests fail. Is this a common use case? Should we add anupdate: 'auto'
option? Or possibly astrict
flag so that the current functionality can be accessed without breaks, but users can alter their workflow to the new version if desired?buildCache
currently leverages the "failed" workflow. In that way should we update the naming conventions throughout to thesaveCurrent
or similar to clarify the usage of the code throughout?