Skip to content

[test-runner-visual-regression] cannot distinguish between chromium browsers(getBaselineName, getDiffName, getFailedName) #1996

Open
@sijakret

Description

@sijakret

Hey,

this context, passed down to the visual diff command (and eventually to the helpers that generate the screenshot file names
only hands down session.browser.name.
This seems to be "chromium" for all chromium-based browsers (like chrome, edge, etc..) so in a session where multiple of these are present the screenshot paths have collisions.
Wouldn't it make sense to hand down more context here (like browser channel and browser version!?)

image

Best,
Jan

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions