Skip to content

[test-runner-visual-regression] Feature Request. extend VisualDiffCommandContext to include launch options #1771

Open
@sijakret

Description

@sijakret

Hi,

when running chrome using the msedge channel like this

playwrightLauncher({ product: 'chromium', launchOptions: { channel: 'msedge' } })

as far as i can see it is currently not possible to access the, for instance, the launch options to generate a different paths for edge and chromium:

const baselineName = options.getBaselineName({ browser, name, testFile });

So if they are running in parallel in one session it is not possible to distinguish them in getBaselineName.

Should we maybe add the launch options to the context available to that method?

export interface VisualDiffCommandContext {

what are your thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions