Skip to content

[dev-server-rollup] Failing test: node modules resolved outside root directory are rewritten with commonjs #1568

@web-padawan

Description

@web-padawan

There is one test failing after upgrading @rollup/plugin-node-resolve to 13.0.0 (#1433).

  1) @rollup/plugin-node-resolve
       node modules resolved outside root directory are rewritten with commonjs:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/web/web/packages/dev-server-rollup/test/node/plugins/node-resolve.test.ts)
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)

See https://github.com/modernweb-dev/web/pull/1567/checks?check_run_id=3159207368

Downgrading back to 11.0.0 makes this test pass. The reason is most likely this PR: rollup/plugins#799

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions