feat: fetch use concurrency #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this Pr. Unless I done the second task. |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 2 2
Lines 20 20
=======================================
Hits 15 15
Misses 4 4
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@zaunist cc. |
|
I decide use unbuffered channel. Becasue i think send and accept should be separated, this is why i don't use buffered channel to do. You can view the code. we limit the goroutine queue number. |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description
Others
In past. We only use one goroutine. In main process. But when we use
grm testcommand. We can found the speed don't ideal. So we should speed up the program with goroutine. According my thoughts. I should mock a func just like in javaScriptPromise.Allto done this work.Why
Promise.All. Because we should guarantee the order of the output.