Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add internal package test case #20

Merged
merged 1 commit into from
May 8, 2022
Merged

test: add internal package test case #20

merged 1 commit into from
May 8, 2022

Conversation

zaunist
Copy link
Member

@zaunist zaunist commented May 8, 2022

Background

Currently, grm has no test cases, we should supplementary test cases

Description

Others

@zaunist
Copy link
Member Author

zaunist commented May 8, 2022

cc @XeryYue

Copy link
Collaborator

@nonzzz nonzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nonzzz
Copy link
Collaborator

nonzzz commented May 8, 2022

you are right. but can we validate the test at ci?

@nonzzz nonzzz merged commit 381012f into modern-magic:master May 8, 2022
@zaunist
Copy link
Member Author

zaunist commented May 8, 2022

you are right. but can we validate the test at ci?

Fine, I would like to do this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants