Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add uri validate #17

Merged
merged 3 commits into from
May 3, 2022
Merged

[Feature]: add uri validate #17

merged 3 commits into from
May 3, 2022

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented May 3, 2022

Description

In past version, We don't verify the uri. so user can entered grm add x y. This is not as expected. So this pr will resolve it.

  • Add validate reg.
  • RegistryDataSource struct add new item.UserRegistry.

@nonzzz nonzzz requested a review from zaunist May 3, 2022 05:57
@nonzzz
Copy link
Collaborator Author

nonzzz commented May 3, 2022

By the way. In past. user can create a custom registry alias same as preset source alias. I think it's a bug.
So i need add item from RegistryDataSource struct. For verify user entered value. @zaunist cc.

Copy link
Member

@zaunist zaunist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@nonzzz nonzzz merged commit 0441585 into modern-magic:master May 3, 2022
@nonzzz nonzzz deleted the feat/validate branch May 3, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants