-
Notifications
You must be signed in to change notification settings - Fork 91
Forward pass for the conv2d layer #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
milancurcic
merged 23 commits into
modern-fortran:main
from
milancurcic:conv2d-forward-pass
May 16, 2022
Merged
Forward pass for the conv2d layer #65
milancurcic
merged 23 commits into
modern-fortran:main
from
milancurcic:conv2d-forward-pass
May 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
conv2d
layerlayer % get_output
method for theconv2d
andinput3d
layersrandn
for 4-d data (used to initialize the convolution kernel)input3d
layernetwork % forward_3d
method under the genericnetwork % forward
nameSome comments:
associate
appears buggy with ifort-2021.5; avoid it (theassociate
construct; not the compiler) for the time being, and revisit and file bug reports once we have a working implementation (i.e. when Add support for convolutional layers #64 is closed).TODO
conv2d
API consistent with the Keras API (i.e.conv2d(filters, kernel_size)
).Closes #60.
CC @katherbreen