-
Notifications
You must be signed in to change notification settings - Fork 91
Get set network parameters #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get set network parameters #111
Conversation
Co-authored-by: Christopher Zapart <chris.zapart@nao.ac.jp>
Make set_params() a subroutine; Co-authored-by: Christopher Zapart <chris.zapart@nao.ac.jp>
I made |
Neat, with |
I added a few more checks, completed the minimal test suite, and tidied up the example. @jvo203 please let me know if you think any more changes are needed. If not, I'll merge it tomorrow. Thanks again for all your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as there is no problem with floating-point comparisons in get_set_network_params.f90
I am happy with it. The ==
in test_get_set_network_params.f90
compares integer values (stored in a real
array) so there should not be any rounding errors etc.
Opening this in favor of #107 by @jvo203. It should be easier to review. I made some small cosmetic changes.
Closes #103.